Skip to content

[Typed throws] Support overrides that are contravariant in the thrown error #69922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2023
Merged

[Typed throws] Support overrides that are contravariant in the thrown error #69922

merged 2 commits into from
Nov 16, 2023

Conversation

@DougGregor
Copy link
Member

@DougGregor DougGregor commented Nov 16, 2023

This enables overrides such as

class Super {
  func f() throws { }
}

class Sub: Super {
  override func f() throws(MyError) { }
}

@DougGregor
Copy link
Member Author

DougGregor commented Nov 16, 2023

@swift-ci please smoke test

@DougGregor DougGregor enabled auto-merge November 16, 2023 18:44
@DougGregor DougGregor mentioned this pull request Nov 16, 2023
Merged
21 tasks
@DougGregor DougGregor merged commit 359c892 into swiftlang:main Nov 16, 2023
@DougGregor DougGregor deleted the typed-throw-overrides branch November 16, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DougGregor