[Parse] Unguard Parser.IsForASTGen for SWIFT_BUILD_SWIFT_SYNTAX #69877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing a field depending on `-D` was not a good idea.
rintaro
requested review from
CodaFi,
DougGregor,
ahoppen and
bnbarham
as code owners
Member
Author
|
@swift-ci Please smoke test |
1 similar comment
Member
Author
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiding a field depending on
-Dwas not a good idea. e.g. #69858 #69761 (comment)cc: @drodriguez