Requirement lowering cleanup and accept-invalid fix for @objc protocols #69866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inference Refactor the code to match what's written up in generics.tex. It's easier to understand what's going on if requirement inference first introduces a bunch of requirements that might be trivial, and then all user-written and inferred requirements are desugared at the end in a separate pass.
Don't quote generic parameter names because then the tau gets escaped in canonical types, and expand out the replacement type with printRec() instead of stringifying it.
slavapestov
requested review from
AnthonyLatsis,
hborla and
xedin
as code owners
|
@swift-ci Please smoke test |
|
swiftlang/swift-driver#1486 |
|
Please smoke test macOS |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't a whole lot you can actually state in the where clause of an @objc protocol, because there are no associated types. But you can state some invalid things, so make sure they get diagnosed.
While I'm here, clean up RequirementLowering.cpp to make the phase separation between requirement inference and requirement desugaring more explicit.