AST/SILGen: Requestify var initializer expression typechecking #69841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Allow initializer expressions to be emitted during SILGen when `-experimental-lazy-typecheck` is specified by introducing a new request that fully typechecks the init expressions of pattern binding declarations on-demand. There are still a few rough edges, like missing support for wrapped properties and incomplete handling of subsumed initializers. Fixing these issues is not an immediate priority because in the short term `-experimental-lazy-typecheck` will always be accompanied by `-enable-library-evolution` and `-experimental-skip-non-exportable-decls`. This means that only the initializers of properties on `@frozen` types will need to be emitted and property wrappers are not yet fully supported on properties belonging to `@frozen` types. Resolves rdar://117448868
tshortli
force-pushed
the
silgen-lazy-typecheck-pattern-executable-init
branch
from
dc3d849 to
111eea7
Compare
Contributor
Author
|
@swift-ci please smoke test |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Nov 16, 2023
…tion. As a follow up to swiftlang#69841, clarify the possible states that initializer expression of a pattern can be in. The possible states are not checked, checked, and "checked and contextualized" (which is the new state that was introduced and requestified in the previous PR). This refactoring encodes the states more explicitly and renames a few compiler APIs to better align with the new naming. NFC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow initializer expressions to be emitted during SILGen when
-experimental-lazy-typecheckis specified by introducing a new request that fully typechecks the init expressions of pattern binding declarations on-demand.There are still a few rough edges, like missing support for wrapped properties and incomplete handling of subsumed initializers. Fixing these issues is not an immediate priority because in the short term
-experimental-lazy-typecheckwill always be accompanied by-enable-library-evolutionand-experimental-skip-non-exportable-decls. This means that only the initializers of properties on@frozentypes will need to be emitted and property wrappers are not yet fully supported on properties belonging to@frozentypes.Resolves rdar://117448868