Typed throws rethrows cleanup #69758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in calls Match what we do in `emitThrow`. Both of these should be unified and generalized, relying on the AST to provide the necessary conversions rather than having SILGen re-derive them.
Rethrows functions only throw when their closure arguments throw. However, they are free to translate the errors thrown from the closure arguments in any way they want, and are therefore untyped. Ensure that calls to `rethrows` functions are always treated as throwing `any Error` if their closure arguments throw anything.
DougGregor
requested review from
hamishknight,
hborla,
slavapestov and
xedin
as code owners
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rethrows functions only throw when their closure arguments throw.
However, they are free to translate the errors thrown from the closure
arguments in any way they want, and are therefore untyped.
Ensure that calls to
rethrowsfunctions are always treated asthrowing
any Errorif their closure arguments throw anything.