Typed throws minor fixes #69741
Merged
Typed throws minor fixes #69741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… block This is the same way we handle `throw` instructions, but without the operand.
Member
Author
|
@swift-ci please smoke test |
…nstruction These were only properly handling SIL-level indirect results, not including indirect error results.
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test Linux |
| llvm::DITypeArray Error = nullptr; | ||
| if (FnTy && (Opts.DebugInfoLevel > IRGenDebugInfoLevel::LineTables)) | ||
| if (auto ErrorInfo = FnTy->getOptionalErrorResult()) { | ||
| GenericContextScope scope(IGM, FnTy->getInvocationGenericSignature()); |
Contributor
There was a problem hiding this comment.
And this is only needed when creating the function signature and not in the body of the function?
Member
Author
There was a problem hiding this comment.
We should verify that; it didn't show up as a crash when putting typed throws into the standard library, but it might be because we aren't providing correct debug info for SIL-level indirect error results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor fixes for typed throws:
throw_addrinstructions by branching to the error basic block