[embedded] Fix class_method devirtualizer to consider specialized VTables #69678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance devirtualizer can introduce / re-introduce generic functions in embedded Swift mode, after MandatoryPerformanceOptimizations has made sure everything is specialized. See the attached test case (actually it's just an existing test but built with -Osize), which currently triggers an IRGen crash due to a generic function being referenced:
Turns out that the Devirtualizer pass turns this
into:
But it should instead call the specialization (from the specialized VTable), not the generic function (from the regular VTable).