Skip to content

AST: Rename getOrigAttrs() to getParsedAttrs() #69599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

AST: Rename getOrigAttrs() to getParsedAttrs() #69599

merged 1 commit into from
Nov 2, 2023

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Nov 2, 2023

To match terminology used elsewhere in the compiler (e.g. "parsed accessor") rename "original attributes" to "parsed atributes". Additionally, make sure the attributes returned by getParsedAttrs() really are just the parsed ones by skipping implicit attributes in addition to the ones expanded from macros.

@tshortli
AST: Rename getOrigAttrs() to getParsedAttrs().
e879c07 
To match terminology used elsewhere in the compiler (e.g. "parsed accessor")
rename "original attributes" to "parsed atributes". Additionally, make sure the
attributes returned by `getParsedAttrs()` really are just the parsed ones by
skipping implicit attributes in addition to the ones expanded from macros.
@tshortli
Copy link
Contributor Author

tshortli commented Nov 2, 2023

@swift-ci please smoke test

ahoppen
ahoppen approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot less confusing. Thank you!

@tshortli tshortli merged commit b74e4a2 into swiftlang:main Nov 2, 2023
@tshortli tshortli deleted the rename-orig-attrs-to-parsed-attrs branch November 28, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen ahoppen approved these changes

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tshortli @bnbarham @ahoppen