SILGen support for throwing indirect errors #69529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
sil-throw-addr
branch
from
d9134f2 to
34b6c04
Compare
Contributor
Author
|
@swift-ci Please smoke test |
eeckstein
reviewed
Oct 31, 2023
slavapestov
force-pushed
the
sil-throw-addr
branch
from
34b6c04 to
c655535
Compare
slavapestov
changed the title
slavapestov
force-pushed
the
sil-throw-addr
branch
from
c655535 to
079c5c4
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a typed throws world, the thrown error type might be address-only. In this case we return it via the new
@error_indirectconvention. The type lowering and SILGen prolog generation for this was previously landed in #69430. This PR makesthrowandtry call(...)work.Throwing is handled with a new
throw_addrinstruction; instead of taking an operand it assumes the indirect error result was initialized already.If the callee has an indirect error result,
try_applytakes a temporary allocation to use as the indirect error result. Then, instead of the thrown error being an argument to the error basic block, we instead assume the indirect error result is live in the error block.Note that
do {} catch {}doesn't work with indirect errors yet.