Fix precondition in UMRBP.initialize(as:fromContentsOf:) #69420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please smoke test |
glessard
approved these changes
Oct 25, 2023
Contributor
glessard
left a comment
glessard
left a comment
There was a problem hiding this comment.
Thanks for catching this, and sorry for the trouble…
This precondition checks to make sure that the content-providing collection isn't larger than the allocated buffer, but was preventing using a buffer that is the exact same size as the collection.
natecook1000
force-pushed
the
umrbp-initmemory-limit
branch
from
4a6c196 to
2c244b9
Compare
Member
Author
|
@swift-ci Please smoke test |
Contributor
|
@swift-ci please test windows platform |
stephentyrone
approved these changes
Oct 26, 2023
Contributor
|
Do we need this on 5.10? |
Contributor
|
Yes, it's a simple bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This precondition checks to make sure that the content-providing collection isn't larger than the allocated buffer, but was preventing using a buffer that is the exact same size as the collection.