[Concurrency] Allow isolated default arguments to be used from across isolation boundaries. #69391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
requested review from
kavon,
ktoso,
slavapestov and
xedin
as code owners
… isolation boundaries.
hborla
force-pushed
the
isolated-default-value-revision
branch
from
1157198 to
49d6399
Compare
Member
Author
|
@swift-ci please build toolchain |
ktoso
approved these changes
Oct 25, 2023
Contributor
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Looks like a good incremental step 👍
Member
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements most of the revision for the isolated default values proposal, which enables isolated default arguments from being used across isolation boundaries. For now, this is done by emitting an actor hop around the evaluation of each isolated default argument. However, as specified by the argument evaluation section of the proposal, we should change argument evaluation order if any default arguments are isolated to the following order:
This intermediate implementation state is to allow the semantics of the proposal to be tested out in a toolchain. This change also still needs some SILGen tests.