SILGen: Fix yet another 'argument labels ignored if parameter type is Any' thing #6927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Any' thing In Swift 3, we had a bug where you could provide argument labels to a function call taking a single Any parameter, even if the parameter did not have a label. This mostly worked (with asserts off!) but in fact it would crash in SILGen if you were calling an enum case constructor. Since this 'feature' has been promoted from 'works on accident' to 'still a hack but guarded by Swift 3 mode and exists on purpose', fix the crash, even though Swift 3 could not compile the code in question. Also add a Swift 3 mode check to the earlier SILGen hack, so that when/if we remove Swift 3 mode it will be obvious that this code is now dead too.
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
|
The gift that keeps on giving... :( |
Contributor
Author
|
Hey, we're not introducing regressions, we're identifying bogus behavior and isolating it behind that flag. Progress :-) |
Contributor
|
Absolutely! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift 3, we had a bug where you could provide argument labels
to a function call taking a single Any parameter, even if the
parameter did not have a label.
This mostly worked (with asserts off!) but in fact it would crash
in SILGen if you were calling an enum case constructor.
Since this 'feature' has been promoted from 'works on accident' to
'still a hack but guarded by Swift 3 mode and exists on purpose',
fix the crash, even though Swift 3 could not compile the code in
question.
Also add a Swift 3 mode check to the earlier SILGen hack, so that
when/if we remove Swift 3 mode it will be obvious that this code is
now dead too.