Move only loadable to address reabstraction #69263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If SILGen emitted a marker, that ought to be indication enough that move only checking is necessary.
… base from loadable to in-memory. The code here was materializing the value in this case, but then re-loading it, which is unnecessary since call emission will materialize the value to match the callee's calling convention already. It does look like a copy into formal evaluation scope is necessary to get the correct lifetimes in some circumstances. The move-only checker doesn't like any additional copies at all because it thinks they're consumes, so only borrow in the case where the value is move-only.
Contributor
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of fixes that allow for noncopyable values to be used successfully as the base of a property projection in situations where the type is loadable, but the property implementation takes its parameter indirectly.