Skip to content

Don't try to infer @objc for non-getter/setter accessors #6926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2017
Merged

Don't try to infer @objc for non-getter/setter accessors #6926

merged 1 commit into from
Jan 20, 2017

Conversation

@jrose-apple
Copy link
Contributor

@jrose-apple jrose-apple commented Jan 20, 2017

These are never part of an @objc protocol, so we shouldn't bother looking for them and certainly shouldn't expect them to be there. Fixes a crash introduced in #6634.

rdar://problem/30101703

@jrose-apple
Don't try to infer @objc for non-getter/setter accessors
91f75d5 
These are never part of an @objc protocol, so we shouldn't bother
looking for them and certainly shouldn't expect them to be there.
Fixes a crash introduced in 1f21213.

rdar://problem/30101703
@jrose-apple
Copy link
Contributor Author

jrose-apple commented Jan 20, 2017

Hoping to cherry-pick to the 3.1 branch too.

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor

slavapestov commented Jan 20, 2017

LGTM

@jrose-apple jrose-apple merged commit d79fc62 into swiftlang:master Jan 20, 2017
@jrose-apple jrose-apple deleted the objc-only-has-getters-and-setters branch January 20, 2017 03:28
jrose-apple added a commit to jrose-apple/swift that referenced this pull request Jan 20, 2017
@jrose-apple
Don't try to infer @objc for non-getter/setter accessors (swiftlang#6926
706bd33 
)

These are never part of an @objc protocol, so we shouldn't bother
looking for them and certainly shouldn't expect them to be there.
Fixes a crash introduced in 1f21213.

rdar://problem/30101703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slavapestov slavapestov Awaiting requested review from slavapestov

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrose-apple @slavapestov