Check thrown error types of for applications/subscripts/property access #69198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
hborla,
kavon,
ktoso,
slavapestov and
xedin
as code owners
Member
Author
|
@swift-ci please smoke test |
This was referenced Oct 16, 2023
Merged
Introduce a new API to find the AST node that catches or rethrows an error thrown from the given source location. Use it to determine the thrown error type to use for type checking a `throw` statement, which begins as `any Error` within a `do..catch` and is later refined.
…s/etc. Whenever there is a throwing operation such as a call, subscript, or property access, check that the error type thrown from that operation can be caught/rethrown from the current context.
While it is not yet possible for an `AsyncSequence` to specify its thrown error type (so it always throws `any Error`), check that `any Error` is a suitable error type to be thrown in context.
DougGregor
force-pushed
the
typed-throws-rethrow-checking
branch
from
9cdfe56 to
7b9c079
Compare
Member
Author
|
@swift-ci please smoke test |
… interface types The implementation of `SimpleDidSetRequest` currently depends on a type-checked body for `didSet`, which in turn depends on the interface type (for the thrown error type). Break that dependency in a silly way for now.
Member
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever there is a throwing operation such as a call, subscript, or
property access, check that the error type thrown from that operation
can be caught/rethrown from the current context.
To do this, introduce a new API to find the AST node that catches or rethrows an
error thrown from the given source location.