Skip to content

Conversation

@edymtt
Copy link
Contributor

@edymtt edymtt commented Oct 13, 2023

We have some configurations in which we run a preset that only builds the compiler, and then a few ones to tests such binary, e.g.

buildbot_incremental,tools=RA,stdlib=RD,build
buildbot_incremental,tools=RA,stdlib=RD,test=macOS,type=device
buildbot_incremental,tools=RA,stdlib=RD,test=iOS,type=simulator
buildbot_incremental,tools=RA,stdlib=RD,test=watchOS,type=simulator

Contrary to the other presets, in the first preset we did not specify "--lit-args" since it is not necessary -- however that plays a part in the configuration of compiler-rt, causing an unwanted rebuild when that parameter is specified in the following preset.

Addresses rdar://116922016

We have some configurations in which we run a preset that only builds
the compiler, and then a few ones to tests such binary, e.g.

```
buildbot_incremental,tools=RA,stdlib=RD,build
buildbot_incremental,tools=RA,stdlib=RD,test=macOS,type=device
buildbot_incremental,tools=RA,stdlib=RD,test=iOS,type=simulator
buildbot_incremental,tools=RA,stdlib=RD,test=watchOS,type=simulator
```

Contrary to the other presets, in the first preset we did not specify
"--lit-args" since it is not necessary -- however that plays a part in
the configuration of compiler-rt, causing an unwanted rebuild when that
parameter is specified in the following preset.

Addresses rdar://116922016
@edymtt edymtt requested a review from shahmishal October 13, 2023 16:38
@edymtt
Copy link
Contributor Author

edymtt commented Oct 13, 2023

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Oct 13, 2023

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Oct 13, 2023

@swift-ci please build toolchain Linux

@edymtt
Copy link
Contributor Author

edymtt commented Oct 13, 2023

@swift-ci please build toolchain Windows

@edymtt
Copy link
Contributor Author

edymtt commented Oct 13, 2023

@swift-ci please test Linux

@edymtt
Copy link
Contributor Author

edymtt commented Oct 16, 2023

@swift-ci please build toolchain Windows

@edymtt
Copy link
Contributor Author

edymtt commented Oct 16, 2023

@swift-ci please build toolchain Linux

@edymtt
Copy link
Contributor Author

edymtt commented Oct 16, 2023

Looks like we have infrastructure issues for the Windows toolchain job

******************** TEST 'Swift(windows-x86_64) :: ModuleInterface/swift_build_sdk_interfaces/find-modules.test-sh' FAILED ********************
...
  File "c:\program files (x86)\microsoft visual studio\shared\python39_64\lib\multiprocessing\reduction.py", line 131, in detach
    return _winapi.DuplicateHandle(
    return _winapi.DuplicateHandle(
PermissionError: [WinError 5] Access is denied
PermissionError: [WinError 5] Access is denied

@edymtt
Copy link
Contributor Author

edymtt commented Oct 16, 2023

@swift-ci please build toolchain Windows

@edymtt edymtt merged commit ef5492d into swiftlang:main Oct 16, 2023
@edymtt edymtt deleted the edymtt/specify-lit-args-to-reduce-rebuilds branch October 23, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant