[wasm] Add @_extern(wasm) attribute support #69107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute instructs the compiler that this function declaration
should be "import"ed from host environment. It's equivalent of Clang's
`__attribute__((import_module("module"), import_name("field")))`
kateinoigakukun
changed the title
Member
Author
|
@swift-ci Please smoke test |
kateinoigakukun
added
WebAssembly
kateinoigakukun
requested review from
CodaFi,
DougGregor,
ahoppen,
bnbarham,
egorzhdan,
hborla,
hyp,
rintaro,
slavapestov,
xedin and
zoecarver
as code owners
al45tair
approved these changes
Oct 12, 2023
Contributor
al45tair
left a comment
al45tair
left a comment
There was a problem hiding this comment.
LGTM. I'm definitely looking forward to @extern(c) being added.
MaxDesiatov
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute instructs the compiler that this function declaration should be "import"ed from host environment. It's equivalent of Clang's
__attribute__((import_module("module"), import_name("field")))The attribute doesn't have any effect on to function signature and calling convention but only adds LLVM meta attribute to the function. Currently there is no way to declare a function with non SwiftCC, so functions are always imported as having SwiftCC. (I'm planning to add
@_extern(c)after this change will be merged. Combination with them makes the declaration to be imported from WebAssembly host using C convention)This is the import version of #68524, which adds an attribute to export functions.
@_extern(wasm, module: <module-name>, name: <name>)wasm-import-nameandwasm-import-moduleResolves rdar://115502075