[test][IRGen] Avoid redefinition of bool in huge_c_type.swift #69059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musl and wasi-libc modules contains stdint.h and stdbool.h in their modulemap, and `#incnlude <stdint.h>` in huge_c_type.h leads including stdbool.h also in the scope. This results in conflicting the bool definition, so we should avoid the redefinition.
Member
Author
|
@swift-ci Please smoke test |
MaxDesiatov
approved these changes
Oct 9, 2023
MaxDesiatov
added
test suite
al45tair
approved these changes
Oct 9, 2023
kateinoigakukun
deleted the
pr-562be51930a6434c568fb2c1d3c2ed1b5b173f63
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
musl and wasi-libc modules contains stdint.h and stdbool.h in their modulemap, and
#incnlude <stdint.h>in huge_c_type.h leads including stdbool.h also in the scope. This results in conflicting the bool definition, so we should avoid the redefinition.