[Autodiff] Modify inliner logic to award inlining benefits to linear … #69029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@BradLarson @asl could one of you please kick off swift-ci? |
Contributor
|
@swift-ci Please test |
Contributor
Author
|
@eeckstein do you think you could also take a look at this PR? |
…maps w/ control-flow For linear maps containing control-flow, closures (representing the pullbacks of intermediate values) may be passed as arguments, however, they may be hidden behind a branch-tracing enum (tracing execution flow of the original function). Such linear maps did not use to get inlining benefits as the compiler could not see that the intermediate pullback closures were actually part of the input. This change modifies the inliner logic to correctly award inlining benefits to linear maps containing control-flow, by checking if a "callee" in the linear map actually traces back to an input closure that was received as part of a branch-tracing enum input argument. Fixes swiftlang#68945
Contributor
|
@swift-ci test |
Contributor
Author
|
I think the windows build might need to be retried. It seems like the build timed out? |
Contributor
|
@swift-ci test |
1 similar comment
Contributor
|
@swift-ci test |
Contributor
|
@swift-ci benchmark |
jkshtj
added a commit
to jkshtj/swift
that referenced
this pull request
Oct 27, 2023
Similar to swiftlang#69029 but for VJPs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For linear maps containing control-flow, closures (representing the pullbacks of intermediate values) may be passed as arguments, however, they may be hidden behind a branch-tracing enum (tracing execution flow of the original function).
Such linear maps did not use to get inlining benefits as the compiler could not see that the intermediate pullback closures were actually part of the input.
This change modifies the inliner logic to correctly award inlining benefits to linear maps containing control-flow, by checking if a "callee" in the linear map actually traces back to an input closure that was received as part of a branch-tracing enum input argument.
Fixes #68945