[embedded] Add a embedded Swift + typed throw test showcasing that we avoid existentials #68977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
kubamracek
force-pushed
the
embedded-typed-throws
branch
from
7e73412 to
7e42771
Compare
Contributor
Author
|
@swift-ci please test |
xedin
reviewed
Oct 5, 2023
test/embedded/throw-typed.swift
Outdated
Contributor
There was a problem hiding this comment.
I keep forgetting whether we still need REQUIRES: asserts when -enable-experimental-feature flag is used or not, could you please double-check?
Contributor
Author
There was a problem hiding this comment.
Some features need asserts, some don't (it's controlled in the Features.def file on a per feature basis). The ones used here don't need asserts.
kubamracek
force-pushed
the
embedded-typed-throws
branch
from
7e42771 to
2b90200
Compare
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual compiler changes are taken from Doug's PR at https://github.com/apple/swift/pull/68976/commits (and I'll wait for that one to land first), I'm only adding the embedded testcase with this one.