[Typed throws] Compute and use the caught error type of a do..catch block #68976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock. The type that is caught by the `catch` clauses in a `do..catch` block is determined by the union of the thrown error types in the `do` statement. Compute this type and use it for the catch clauses. This does several things at once: * Makes the type of the implicit `error` be a more-specific concrete type when all throwing sites throw that same type * When there's a concrete type for the error, one can use patterns like `.cancelled` * Check that this error type can be rethrown in the current context * Verify that SIL generation involving do..catch with typed errors doesn't require any existentials.
Member
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type that is caught by the
catchclauses in ado..catchblock is determined by the union of the thrown error types in thedostatement. Compute this type and use it for the catch clauses. This does several things at once:errorbe a more-specific concrete type when all throwing sites throw that same type.cancelled