[Tests] Mark macro test 'REQUIRES: swift_swift_parser' #68867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham and
hamishknight
as code owners
Member
Author
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Sep 29, 2023
Member
Author
|
@swift-ci Please smoke test |
compnerd
approved these changes
Sep 29, 2023
rintaro
force-pushed
the
macros-rdar116239522
branch
from
4acbad1 to
8159f5e
Compare
Member
Author
|
@swift-ci Please smoke test |
This was referenced Sep 29, 2023
rdar://116239522
`.dylib` was hardcoded. Accept other platforms' shared library filenames
rintaro
force-pushed
the
macros-rdar116239522
branch
from
8159f5e to
5ad543a
Compare
Member
Author
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
macros-rdar116239522
branch
from
5ad543a to
203a2b8
Compare
Member
Author
|
@swift-ci Please smoke test |
compnerd
approved these changes
Sep 30, 2023
After FetchContent changes, macros in Windows were disabled.
build-windows-toolchain.bat used to build and install 'swift-syntax' for the compiler. Now that swift-syntax is built as a part of 'swift' build. So no need to built it separately anymore.
rintaro
force-pushed
the
macros-rdar116239522
branch
from
203a2b8 to
fc03e2e
Compare
Member
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://116239522