[5.10][Concurrency] An assortment of bug fixes in Sendable and actor isolation checking.
#68852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt'. This commit is NFC; it's mostly renames. (cherry picked from commit a6d078b)
…ties from nonisolated subclass initializers. (cherry picked from commit 90ccc75)
nonisolated closure in an actor-isolated context. (cherry picked from commit 9b16d47)
…rences for Sendability. Sendability of function references depends only on captures, and applies when the function itself is passed across isolation boundaries. Parameter and result values can only cross isolation boundaries when the function is called. (cherry picked from commit 553fe45)
getClosureActorIsolation. This is preparation for changing AbstractClosureExpr to store ActorIsolation instead of ClosureActorIsolation, and convert to ClosureActorIsolation when needed to allow incrementally updating callers. This change is NFC. (cherry picked from commit 4b23564)
ClosureActorIsolation. (cherry picked from commit 54f5fef)
…ghout the isolation query APIs. (cherry picked from commit 97f1e61)
(cherry picked from commit 549b452)
…versions to impact constraint solving. (cherry picked from commit 2e9c64d)
…ions. (cherry picked from commit 2159c0c)
Now that there's only one call-site of `safeToDropGlobalActor`, it doesn't need to be exposed in the ActorIsolation header, and it doesn't need to avoid `warnUntilSwiftVersion` to match constraint system diagnostics. (cherry picked from commit 2fb14ce)
(cherry picked from commit 00ff491)
Member
Author
|
@swift-ci please test |
DougGregor
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nonisolatedinitializer of a subclass could invoke global-actor-isolated properties in the superclass.Sendablechecking for function references where parameter and result types wereSendable-checked at the point of partial application when there was no function conversion. Sendability of function references depends only on captures, and applies when the function itself is passed across isolation boundaries. Parameter and result values can only cross isolation boundaries when the function is called, so they shouldn't be checked when checking a reference for Sendable violations.This change also includes a minor refactoring to consolidate the representation of actor isolation across function declarations and closures.
test/Concurrency/.ClosureActorIsolation. #68567