SIL: Fix opaque type erasure after clearing [serialized] flags #68630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
fix-rdar115355709
branch
from
88fb887 to
e083490
Compare
slavapestov
force-pushed
the
fix-rdar115355709
branch
from
e083490 to
fbd8f44
Compare
Contributor
Author
|
@swift-ci Please smoke test |
nate-chandler
approved these changes
Sep 20, 2023
Contributor
|
Thank you for fixing this |
After serialization, we no longer need to enforce the resilience boundary between inlinable and non-inlinable functions, so we make a pass over the SIL to clear [serialized] flags and substitute any opaque return types. The logic for AST types was wrong; we can't just lower the type and get the AST type out. Instead, do the same thing that TypeSubstCloner does. Fixes rdar://problem/115355709.
slavapestov
force-pushed
the
fix-rdar115355709
branch
from
fbd8f44 to
ce3b2a4
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/115355709.