[stdlib] Remove the essential/non-essential file split in the stdlib #68504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
approved these changes
Sep 13, 2023
Contributor
zoecarver
left a comment
zoecarver
left a comment
There was a problem hiding this comment.
Seems like a nice improvement. Thanks, Kuba :)
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SWIFT_CHECK_ESSENTIAL_STDLIB seems to be unused and broken in several ways -- it doesn't even pass CMake configuration if enabled, and if I actually try to get only the essential files to build as a stdlib, I get a compiler hang.