Legacy Driver: Make --ld-path option consistently use single dash
#68495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vast majority of other options on Swift Driver already use a single dash.
MaxDesiatov
added
legacy driver
|
@swift-ci test |
|
@swift-ci build toolchain |
kabiroberai
added a commit
to kabiroberai/swift-package-manager
that referenced
this pull request
Sep 14, 2023
Upstream dependencies: swiftlang/swift#68495 swiftlang/swift-driver#1441
|
@swift-ci test windows |
|
@swift-ci build toolchain Windows |
|
The Windows toolchain issue is unrelated to this change:
It seems that we need to tweak a few things. |
|
@swift-ci please build toolchain Windows platform |
MaxDesiatov
pushed a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Sep 19, 2023
This PR implements support for the `linker.path` field in the Swift SDK toolset spec. Depends on swiftlang/swift#68495 and swiftlang/swift-driver#1441. ### Motivation: This field was previously parsed but not respected. ### Modifications: Add `-ld-path=\(linker.path)` to the toolchain's Swift flags if a linker path override is supplied ### Result: The linker path is now respected.
MaxDesiatov
pushed a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Sep 28, 2023
This PR implements support for the `linker.path` field in the Swift SDK toolset spec. Depends on swiftlang/swift#68495 and swiftlang/swift-driver#1441. ### Motivation: This field was previously parsed but not respected. ### Modifications: Add `-ld-path=\(linker.path)` to the toolchain's Swift flags if a linker path override is supplied ### Result: The linker path is now respected.
MaxDesiatov
pushed a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Sep 28, 2023
This PR implements support for the `linker.path` field in the Swift SDK toolset spec. Depends on swiftlang/swift#68495 and swiftlang/swift-driver#1441. ### Motivation: This field was previously parsed but not respected. ### Modifications: Add `-ld-path=\(linker.path)` to the toolchain's Swift flags if a linker path override is supplied ### Result: The linker path is now respected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
--ld-pathoption hasn't been included in a released version yet, so it's ok to break.The vast majority of other options on Swift Driver already use a single dash.