[NFC] Replace std::unordered_map with llvm::DenseSet in metadata reader #68465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
| /// The dense map info for a std::pair<StoredPointer, bool>. | ||
| struct DenseMapInfoTypeCacheKey { | ||
| using Pair = std::pair<StoredPointer, bool>; | ||
| using StoredPointerInfo = llvm::DenseMapInfo<StoredPointer>; |
Contributor
There was a problem hiding this comment.
This shouldn't be necessary. DenseMapInfo has already a generic specialization for std::pair as long as both elements are supported. You should only need to define this for StoredPointer if at all.
Contributor
Author
There was a problem hiding this comment.
DenseMapInfo has already a generic specialization for std::pair as long as both elements are supported
bool is not supported since it can't implement getEmptyKey or getTombstoneKey. This implementation uses only the StoredPointer's implementation for both those functions.
mikeash
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.