[CMake] Use explicit RPATHs for unit test executables #68388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
cmake-unittest-rpath
branch
from
341daea to
e544164
Compare
Member
Author
|
@swift-ci Please smoke test |
Instead of letting CMake set RPATH of the test executables, use INSTALL_RPATH and BUILD_WITH_INSTALL_RPATH just like other executable and shared libraries. Previously when a swift module link with exported swift-syntax targets e.g. 'SwiftSyntax::SwiftParser', the libraries in earlyswiftsyntax were used instead of the copied libraries in the swift build directory. That wasn't ideal.
rintaro
force-pushed
the
cmake-unittest-rpath
branch
from
e544164 to
891d7b7
Compare
Member
Author
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Sep 8, 2023
This was referenced Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of letting CMake set RPATH of the test executables, use
INSTALL_RPATHandBUILD_WITH_INSTALL_RPATHjust like other executable and shared libraries.Previously when a swift module link with exported swift-syntax targets e.g. 'SwiftSyntax::SwiftParser', the libraries in earlyswiftsyntax were used instead of the copied libraries in the swift build directory. That wasn't ideal.