Sema: leak rather than corrupt memory #68267
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`UnsafeMutableBufferPointer.allocate` does not guarantee usage of `malloc` (and in fact guarantees the opposite due to alignment assumptions). The memory allocated by that must be released by `UnsafeMutableBufferPointer.deallocate` only as that is guaranteed to correctly call the deallocation routine. Leak memory rather than corrupting memory.
compnerd
requested review from
CodaFi,
hborla,
slavapestov,
xedin and
zoecarver
as code owners
Remove more cross-domain frees.
|
This should be subsumed by #68271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnsafeMutableBufferPointer.allocatedoes not guarantee usage ofmalloc(and in fact guarantees the opposite due to alignment assumptions). The memory allocated by that must be released byUnsafeMutableBufferPointer.deallocateonly as that is guaranteed to correctly call the deallocation routine. Leak memory rather than corrupting memory.