[AST] ASTScope: Pass parent module to all search methods #68243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses recently discovered performance regression. `findChildContaining` has to handle macros and for that it needs a parent module, looking it up every time is expensive because it involves walking up back to a source file scope. Resolves: rdar://114667408 Resolves: rdar://114667496
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses recently discovered performance regression.
findChildContaininghas to handle macros and for thatit needs a parent module, looking it up every time is expensive
because it involves walking up back to a source file scope.
Resolves: rdar://114667408
Resolves: rdar://114667496