[Completion] ~CCResultBuilder must be called after ~ExpectedTypeContext #68231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
preset=asan |
rintaro
approved these changes
Aug 31, 2023
hamishknight
approved these changes
Aug 31, 2023
Contributor
|
Also nit: shouldn't the PR title read as the following? :)
|
Contributor
Author
Hah, indeed it should 😅. I renamed that title a whole bunch of times trying to fit it in 80 characters. |
There's a subtle stack UAF here - `~CodeCompletionResultBuilder` would be called *after* `~ExpectedTypeContext` as `ExpectedTypeContext` was defined after `CodeCompletionResultBuilder`. Fix the order they're created to prevent this.
bnbarham
force-pushed
the
fix-stack-use-after-free
branch
from
40c6d73 to
020f2b5
Compare
Contributor
Author
|
@swift-ci please smoke test |
Member
|
@swift-ci Please smoke test Linux |
ahoppen
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a subtle stack UAF here -
~CodeCompletionResultBuilderwould be called after~ExpectedTypeContext. Fix the order they're created.