[CopyPropagation] Don't try to delete owned values on which canonicalization bails. #68090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test linux platform |
|
Trivial types can be dead code eliminated. Whether they are Copyable is irrelevant. This should already be handled correctly by If you add a struct-deinit to your type, are we still shortening the lifetime? That would be wrong. Similar problem if the type has a member which has a struct-deinit |
atrick
requested changes
Aug 23, 2023
Owned lifetime canonicalization bails on move-only values. Previously, though, every value that was fed to canonicalization was then attempted to be deleted. For dead move-only values, the result could be to shorten move-only lifetimes, which is illegal per language rules. Here, this is fixed by not attempting to delete owned values for which canonicalization bailed. rdar://114323803
nate-chandler
force-pushed
the
rdar114323803
branch
from
dfd2e8b to
a67c22d
Compare
|
@atrick Fixed. |
|
@swift-ci please test and merge |
atrick
approved these changes
Aug 23, 2023
|
@swift-ci please test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Owned lifetime canonicalization bails on move-only values.
Previously, though, every value that was fed to canonicalization was then attempted to be deleted. For dead move-only values, the result could be to shorten move-only lifetimes, which is illegal per language rules.
Here, this is fixed by not attempting to delete owned values for which canonicalization bailed.
rdar://114323803