[silgen] Hide ManagedValue::forUnmanaged and rewrite all uses to use more specific APIs #68024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an old API that should have been renamed a long time ago. It just kept its early name due to inertia.
…use other more specific APIs. I have been doing this over the past couple of days in preparation for changing ManagedValue to specify the type of scope its cleanup is connected to.
…WithinComponent to be nullptr.
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test source compatibility |
Contributor
Author
|
I am not going to wait for the release compatibility suite since I was just checking for assertions after SILGen. So debug is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just further work so I can force ManagedValues to specify the scope that their lifetime is part of.