[stdlib] Replacing M_PI with .pi #6802
Conversation
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please smoke test and merge |
stephentyrone
left a comment
stephentyrone
left a comment
There was a problem hiding this comment.
A few simplifications are possible because CGFloat also has .pi, whereas M_PI was Double. Those may be outside the scope of this change, however.
| public init(rotationByDegrees angle: CGFloat) { | ||
| let α = Double(angle) * M_PI / 180.0 | ||
| let α = Double(angle) * .pi / 180.0 | ||
| self.init(rotationByRadians: CGFloat(α)) |
There was a problem hiding this comment.
These could be cleaned up further, I think; there's no long any need for the conversions.
self.init(rotationByRadians: angle * .pi / 180)
Possibly outside the scope of this change.
There was a problem hiding this comment.
Oh. right! CGFloat conforms to the same protocol. Makes perfect sense. Thanks!
|
|
||
| var tenEighty = AffineTransform.identity | ||
| tenEighty.rotate(byRadians: CGFloat(6 * M_PI)) | ||
| tenEighty.rotate(byRadians: CGFloat(6 * Double.pi)) |
There was a problem hiding this comment.
Similarly, these could just be tenEighty.rotate(byRadians: 6 * .pi).
ghost
mentioned this pull request
|
@swift-ci Please test and merge |
3 participants
M_PIhas recently been deprecated. Replacing it's usages to avoid compilation warnings.