Skip to content

Rdar 29016063 swift 3.1 branch precompile bridging header #6768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 13, 2017
Merged

Rdar 29016063 swift 3.1 branch precompile bridging header #6768

merged 10 commits into from
Jan 13, 2017

Conversation

@graydon
Copy link
Contributor

@graydon graydon commented Jan 13, 2017

Cherry-pick for swift-3.1-branch of #5977

Includes option setting the bridging PCH system to off by default.

See rdar://29016063

graydon added 10 commits January 12, 2017 17:00
@graydon
[Bridging PCH] Add ClangImporter::emitBridgingPCH.
4609464
@graydon
[Bridging PCH] Add -emit-pch to Frontend; call emitBridgingPCH.
f36f2af
@graydon
[Bridging PCH] Store ClangImporter::BridgingHeaderLookupTable indirec…
56c4acf 
…tly.
@graydon
[Bridging PCH] Populate bridging lookup table when reading MK_PCH mod…
7ac9b16 
…ule.
@graydon
[Bridging PCH] Pass .pch bridging headers to clang -import-pch
4617828
@graydon
[Bridging PCH] Add testcase for emitting, importing a bridging PCH file.
ddc997e
@graydon
[Bridging PCH] Auto-generate and use temporary bridging PCHs from dri…
2d398b6 
…ver.
@graydon
[Bridging PCH] Warn on non-redundant implicit bridging-header imports.
b90f524 
We're trying to get rid of implicit bridging-header imports, as a feature.
These are IMPORTED_HEADER blocks left in modules built with bridging
headers, that trigger re-importing the bridging header into any client
that imports the module.

As a half-way measure to deprecating them, we add a warning here that
triggers when an implicit bridging-header import occurs that is _not_
suppressed as redundant by clang.
@graydon
[Bridging PCH] Handle mixed PCH + implicit bridging header imports.
75fc21b 
This happens fairly regularly in unit testing scenarios.
@graydon
[Bridging PCH] Add -enable-bridging-pch option, set default to disabled.
d557114
@tkremenek
Copy link
Member

tkremenek commented Jan 13, 2017

@swift-ci test

@graydon
Copy link
Contributor Author

graydon commented Jan 13, 2017

Unfortunately it won't build without its corresponding change in clang: apple/swift-clang#61

@jrose-apple
Copy link
Contributor

jrose-apple commented Jan 13, 2017

Which we can do!

apple/swift-clang#61
@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jan 13, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - d557114
Test requested by - @jrose-apple

@jrose-apple
Copy link
Contributor

jrose-apple commented Jan 13, 2017

…unless update_checkout fails for some reason. @erg?

@swift-ci
Copy link
Contributor

swift-ci commented Jan 13, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - d557114
Test requested by - @jrose-apple

@graydon
Copy link
Contributor Author

graydon commented Jan 13, 2017

apple/swift-clang#61
@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jan 13, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - d557114
Test requested by - @graydon

@swift-ci
Copy link
Contributor

swift-ci commented Jan 13, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - d557114
Test requested by - @graydon

@graydon
Copy link
Contributor Author

graydon commented Jan 13, 2017

"18:39:57 NameError: global name 'lock' is not defined" uh yes, that's not me!

@tkremenek tkremenek merged commit badaeb2 into swiftlang:swift-3.1-branch Jan 13, 2017
@erg
Copy link
Contributor

erg commented Jan 13, 2017 •
edited
Loading

The swift-3.1-branch got the update-checkout parallelize patch but not the fix for that patch 8526d16.

If you use shell.run before calling run_parallel the lock that synchronizes writes to console is not initialized yet.

This patch 8526d16 should get into swift-3.1-branch.

@erg erg mentioned this pull request Jan 13, 2017
Merged
@graydon graydon deleted the rdar-29016063-swift-3.1-branch-precompile-bridging-header branch January 18, 2017 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@graydon @tkremenek @jrose-apple @swift-ci @erg