[5.9][CSRanking] Augment overload ranking to account for variadic generics #67456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ric overloads Since this type of early favoring checks number of arguments and matches labels it would always favor non-variadic overloads which is incorrect. (cherry picked from commit 59908ee)
If one of the choices is variadic generic, let's use `matchCallArguments` to find argument/parameter mappings and form pack expansions for arguments when necessary. Resolves: rdar://112029630 (cherry picked from commit b98cd11)
Contributor
Author
|
@swift-ci please test |
hborla
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #67435
Implements ranking of variadic generic overloads.
If one of the choices is variadic generic, let's use
matchCallArgumentsto find argument/parameter mappings and form pack expansions for arguments
when necessary.
Scope: References to overloaded functions with variadic generic overloads.
Main Branch PRs: [CSRanking] Augment overload ranking to account for variadic generics #67435
Resolves: rdar://112029630
Risk: Low
Reviewed By: @hborla
Testing: Added test-cases to the suite.
Resolves: rdar://112029630