[Observation] Switch to peer instead of arbitrary macros #67289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adopts `@attached(peer)` for generating an observable type's underscored storage when expanding the `@ObservationTracked` macro, instead of using `arbitrary` with the member macro on the observable type.
Member
Author
|
Tests are currently crashing with this error, even if only instantiating an |
Member
Author
|
@swift-ci Please test |
phausler
approved these changes
Jul 13, 2023
Contributor
phausler
left a comment
phausler
left a comment
There was a problem hiding this comment.
Provided we can alleviate the compiler crash, this seems correct to me
This was referenced Jul 14, 2023
Member
|
@swift-ci please test |
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test and merge |
natecook1000
force-pushed
the
observation_peer_macros
branch
from
8e9cca1 to
e68395c
Compare
Member
Author
|
@swift-ci Please test and merge |
natecook1000
pushed a commit
to natecook1000/swift
that referenced
this pull request
Jul 24, 2023
…_macros [Observation] Switch to peer instead of arbitrary macros
natecook1000
added a commit
that referenced
this pull request
Jul 25, 2023
…67484) [Observation] Switch to peer instead of arbitrary macros Co-authored-by: swift-ci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adopts
@attached(peer)for generating an observable type's underscored storage when expanding the@ObservationTrackedmacro, instead of usingarbitrarywith the member macro on the observable type.rdar://110327683