Skip to content

Remove useless if statement #67286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

Remove useless if statement #67286

merged 1 commit into from
Jul 24, 2023

Conversation

@RemiBardon
Copy link

@RemiBardon RemiBardon commented Jul 13, 2023

I just stumbled upon a useless if statement, we can remove it.

@Azoy Azoy requested a review from compnerd July 13, 2023 20:53
compnerd
compnerd reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand how this is a "useless" if. The host compiler is not guaranteed to be clang, it may be MSVC/XLC/SunProCC/GCC/etc. Is there a previous check that guarantees that is not the case?

@RemiBardon
Copy link
Author

RemiBardon commented Jul 17, 2023

We are in a elseif branch of if("${CMAKE_C_COMPILER_ID}" MATCHES "Clang"), so if(NOT "${CMAKE_C_COMPILER_ID}" MATCHES "Clang") must be false, unless I’m mistaken or misread.

@RemiBardon RemiBardon requested a review from compnerd July 24, 2023 07:12
@compnerd
Copy link
Member

compnerd commented Jul 24, 2023

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 1835aaf into swiftlang:main Jul 24, 2023
@RemiBardon RemiBardon deleted the fix-2023-07-13-a branch July 24, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RemiBardon @compnerd @swift-ci