SILArguments now must always have ValueOwnershipKind #6724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses pass in said value. This in the case of insertFunctionArgument requires a ValueOwnershipKind to be specified since we use that for transformations of function argument lists that are only correct after the transformation is complete. This only occurs in FunctionSignatureOptimizations. On the other hand, createFunctionArgument is only used to construct completely new argument lists, so we can instead just rely on the function we are in rather than require the user to pass it in. rdar://29791263
…correct ValueOwnershipKind into FunctionSignatureOpts. rdar://29791263
…nership kind and create a verifier check that this is preserved. rdar://29791263
… in Semantic SIL. Most of this involved sprinkling ValueOwnershipKind::Owned in many places. In some of these places, I am sure I was too cavalier and I expect some of them to be trivial. The verifier will help me to track those down. On the other hand, I do expect there to be some places where we are willing to accept guaranteed+trivial or owned+trivial. In those cases, I am going to provide an aggregate ValueOwnershipKind that will then tell SILArgument that it should disambiguate using the type. This will eliminate the ackwardness from such code. I am going to use a verifier to fix such cases. This commit also begins the serialization of ValueOwnershipKind of arguments, but does not implement parsing of value ownership kinds. That and undef are the last places that we still use ValueOwnershipKind::Any. rdar://29791263
Contributor
Author
|
@swift-ci Please test and merge |
Contributor
Author
|
Playground logger failure is not mine. Infrastructure issue (couldn't connect to window server?!) |
Contributor
Author
|
@swift-ci Please smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a sequence of commits that:
rdar://29791263