AST: Replace TypeArrayView<GenericTypeParamType> with ArrayRef<GenericTypeParamType *> #67037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cTypeParamType *> This basically undoes 3da6fe9, which in hindsight was wrong. There were no other usages of TypeArrayView anywhere else except for GenericSignature::getGenericParams(), and it was almost never what you want, so callers had to convert back and forth to an ArrayRef. Remove it.
slavapestov
requested review from
AnthonyLatsis,
QuietMisdreavus,
hborla,
tshortli and
xedin
as code owners
slavapestov
changed the title
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
swiftlang/llvm-project#7045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were no other usages of TypeArrayView anywhere else except for
GenericSignature::getGenericParams(), and it was almost never what
you want, so callers had to convert back and forth to an ArrayRef.
Remove it.