[Distributed] Try to make test for null sourcefile #66852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
refs #66842 |
xedin
reviewed
Jun 22, 2023
Contributor
There was a problem hiding this comment.
Regardless of source null issue I think it's good to have a round-trip test like we have for property wrappers - https://github.com/apple/swift/blob/main/test/ModuleInterface/property_wrappers.swift. It emits swiftinterface, type-checks it and uses it to emit a module.
ktoso
force-pushed
the
wip-try-to-make-test
branch
from
fec76ef to
a1b7aa5
Compare
Contributor
Author
|
I did a roundtrip test, does this look good @xedin ? |
Contributor
Author
|
@swift-ci please smoke test |
ktoso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test does not trigger the "source file is null" branch though, I'm trying to find out how to test this.