Skip to content

Fix MSVC errors compiling GenMeta.cpp #6683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2017
Merged

Fix MSVC errors compiling GenMeta.cpp #6683

merged 1 commit into from
Jan 10, 2017

Conversation

@hughbe
Copy link
Contributor

@hughbe hughbe commented Jan 9, 2017

All of these are of the form:

error C3200: 'swift::TargetMetadata': invalid template argument for template parameter 'Pointee', expected a class template

Although Metadata.h lives in the runtime (which can't be compiled with MSVC), it is included by GenMeta.cpp (which can be compiled with MSVC). This means that Metadata.h must compile with MSVC

@CodaFi
Copy link
Contributor

CodaFi commented Jan 9, 2017

@swift-ci please smoke test.

@slavapestov slavapestov merged commit fa8f308 into swiftlang:master Jan 10, 2017
@hughbe hughbe deleted the genmeta-msvc branch January 10, 2017 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hughbe @CodaFi @slavapestov