[5.9] MoveOnlyChecker: Look through convert_function of nonescaping closures.
#66823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…res. Like a nested partial_apply reabstraction, but without the thunk, these change the representation of the function but can't escape it without breaking the nonescaping closure promotion. rdar://111060678
Contributor
Author
|
@swift-ci Please test |
gottesmm
approved these changes
Jun 21, 2023
DougGregor
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rdar://111060678
• Explanation: Certain uses of nonescaping closures that capture noncopyable values as arguments to a generic function call would cause the compiler to incorrectly raise an error about unknown use of the noncopyable value.
• Scope of Issue: Reject-valid bug.
• Origination: Noncopyable types feature work.
• Risk: Low -- Change only affects new code adopting noncopyable types. The fix is a one-liner filling in an unhandled SIL instruction in the move-only checker.
• Reviewed By: @gottesmm
• Automated Testing: Swift CI
• Dependencies: None
• Builder Impact: Not applicable
• Directions for QE: None