Scalability fix and cleanups #6665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were relying on the 'validate for layout' path validating these, but that's going to change.
For all types, we can safely skip nested nominal types and typealiases. For a struct, we only have to look at VarDecls; methods never affect layout. Similarly for an enum, only EnumElementDecls matter. For a class, we still have to look at all methods and properties. Ideally, in non-optimized builds we would invoke virtual methods by calling thunks, and only emit the thunks from the translation unit containing the class. Then the layout of a class will only be necessary if you subclass the class. This should improve compiler scalability in multiple-frontend mode.
Contributor
Author
|
@swift-ci Please smoke test |
It looks like we print generic parameters differently from typealiases created to point to them.
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a nominal type declaration from another file was referenced, Sema would validate all of its members, so that SILGen knows the stored property layout of structs, vtable layout for classes and witness table layouts for protocols. However, instead of validating all of the members of each referenced nominal type, it is safe to skip certain members. Tighten this up and add a compiler_scale test using @graydon's framework.
The other patches in this PR are just a couple of small unrelated cleanups.