Call python3 to execute XCTest's build_script.py. #66415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workaround for the fact that fixing this in XCTest's repository (swiftlang/swift-corelibs-xctest#441) is blocked on XCTest's CI being broken for unrelated reasons (and ones which I cannot reproduce).
|
@swift-ci Please test |
shahmishal
approved these changes
Jun 7, 2023
MaxDesiatov
added a commit
that referenced
this pull request
Jun 15, 2023
[5.8] Call python3 to execute XCTest's build_script.py A workaround for the fact that fixing this in XCTest's repository (swiftlang/swift-corelibs-xctest#441) is blocked on XCTest's CI being broken for unrelated reasons (and ones which I cannot reproduce). Risk: low, all other Python scripts in the `swift` and `swift-package-manager` repositories already include this change and use `python3` in both `main` and `release/5.9` branches. This specific change has been on the `main` and `release/5.9` branches for a while now. Original PRs: #65958 for `main` and #66415 for `release/5.9` Reviewed by: @compnerd, @al45tair, and @shahmishal Resolves: unblocks PRs on the `swift-corelibs-foundation` repository that build XCTest as a part of their CI jobs. Tests: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround for the fact that fixing this in XCTest's repository (swiftlang/swift-corelibs-xctest#441) is blocked on XCTest's CI being broken for unrelated reasons (and ones which I cannot reproduce).
rdar://110404757