[borrowing/consuming] Be sure to visit boxes with trivial @moveonly types. #66402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicitcopy_borrowing_parameters.swift. I found on 5.9 that this caught a small issue in MoveOnlyWrappedTypeLowering. I am going to fix that issue in the next commit.
…ypes. This was not caught on main since I wasn't the tests with -sil-verify-all enabled... but it seems that it was caught by the verifier on 5.9. I have since enabled sil-verify-all by default on both of those tests (noimplicitcopy_consuming_parameter.swift and noimplicitcopy_borrowing_parameter.swift). rdar://110364874
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not caught on main since I wasn't the tests with -sil-verify-all
enabled... but it seems that it was caught by the verifier on 5.9. I have since
enabled sil-verify-all by default on both of those tests
(noimplicitcopy_consuming_parameter.swift and
noimplicitcopy_borrowing_parameter.swift).
rdar://110364874