[Backtracing][Tests] Disable crashing tests under ASAN. #66074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al45tair
added
🍒 release cherry pick
Contributor
Author
|
Explanation: Some of the backtracer tests crash deliberately and look to make sure the backtracer is generating the right output. When ASAN is enabled, it catches the crashes instead of the backtracer catching them, so the output doesn't match. Therefore, disable these tests for ASAN builds. |
al45tair
force-pushed
the
eng/PR-109706334
branch
from
d352466 to
8b49f02
Compare
If ASAN is enabled, it will catch the crashes and the backtracing code won't, so in that case the tests will fail. Fix by disabling them for ASAN. rdar://107129465
al45tair
force-pushed
the
eng/PR-109706334
branch
from
8b49f02 to
4639799
Compare
Contributor
Author
|
@swift-ci Please test |
airspeedswift
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ASAN is enabled, it will catch the crashes and the backtracing code won't, so in that case the tests will fail. Fix by disabling them for ASAN.
rdar://109706334