Skip to content

Conversation

@mikeash
Copy link
Contributor

@mikeash mikeash commented May 19, 2023

Cherry-pick #65972 to release/5.9.

Describe in more detail how an object can end up with a non-zero refcount on deallocation, and the consequences.

rdar://109045333

Describe in more detail how an object can end up with a non-zero refcount on deallocation, and the consequences.

rdar://109045333
(cherry picked from commit dc3416b)
@mikeash mikeash requested a review from a team as a code owner May 19, 2023 20:15
@mikeash
Copy link
Contributor Author

mikeash commented May 19, 2023

• Description: This improves the fatal error message when an object escapes its deinit. The original message assumed a little too much familiarity with the implications of such escapes.
• Risk: Very low. This adjusts the message for a fatal error that's already present.
• Original PR: #65972
• Reviewed By: @al45tair
• Testing: The Swift test suite checks for this fatal error. Not all of the exact wording is tested.
• Resolves: rdar://109045333

@al45tair
Copy link
Contributor

@swift-ci Please test

@mikeash mikeash merged commit e66aded into swiftlang:release/5.9 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants