MoveOnlyAddressChecker: Reintroduce debug info for variables after reassignment. #65992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test Linux |
gottesmm
reviewed
May 18, 2023
Contributor
There was a problem hiding this comment.
Btw, for future reference. I introduced a new API on SILUndef that takes a SILValue and grabs the type/SILModule from it. https://github.com/apple/swift/blob/a1219cc6625991ac13b0187a801ac1eb358e92ee/include/swift/SIL/SILUndef.h#L36
…assignment. After a value is consumed, we emit a `debug_value undef` to indicate that the variable value is no longer valid to the debugger. However, once a value is reassigned, it becomes valid again, so emit a `debug_value %original_address` to reassociate the variable with the valid memory location. rdar://109218404
jckarter
force-pushed
the
debug-info-for-move-only-reinitialization
branch
from
f83babf to
51f75c9
Compare
Contributor
Author
|
@swift-ci Please test |
gottesmm
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a value is consumed, we emit a
debug_value undefto indicate that the variable value is no longer valid to the debugger. However, once a value is reassigned, it becomes valid again, so emit adebug_value %original_addressto reassociate the variable with the valid memory location. rdar://109218404