[ObjcHeader] Fix objc header generation when pch is explicited passed #65985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When swift-frontend is explicitly passed the pch file as bridging header on command-line through `-import-objc-header`, it needs to print the original source file name if needed to the generated objc header. rdar://109411245
cachemeifyoucan
requested review from
egorzhdan,
hyp and
zoecarver
as code owners
Contributor
Author
|
@swift-ci please smoke test |
benlangmuir
reviewed
May 17, 2023
artemcm
approved these changes
May 18, 2023
Contributor
artemcm
left a comment
artemcm
left a comment
There was a problem hiding this comment.
I think this is reasonable. Thank you.
benlangmuir
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swift-frontend is explicitly passed the pch file as bridging header on command-line through
-import-objc-header, it needs to print the original source file name if needed to the generated objc header.rdar://109411245